feat(conventional_commits): add ability to overide settings from tool…#1570
Open
AxTheB wants to merge 2 commits intocommitizen-tools:masterfrom
Open
feat(conventional_commits): add ability to overide settings from tool…#1570AxTheB wants to merge 2 commits intocommitizen-tools:masterfrom
AxTheB wants to merge 2 commits intocommitizen-tools:masterfrom
Conversation
github-actions
bot
added
pr-status: wait-for-review
type: feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
+ Coverage 97.33% 98.26% +0.92%
==========================================
Files 42 58 +16
Lines 2104 2714 +610
==========================================
+ Hits 2048 2667 +619
+ Misses 56 47 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I decided not to drag in the jinja2.Template/string.Template dichotomy, as jinja2 is project dependency so the string.Template part will be unused. |
….commitizen.customize
…2 is standard dependency
AxTheB
force-pushed
the
feat/customizable-conventional-commits
branch
from
2cfd272 to
80b550c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….commitizen.customize
Description
Adds ability to override settings using [tool.commitizen.customize] in the cz_conventional_commits
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
You use
conventional_commitscommitizen, and using [tool.commitizen.customize] config section you override selected settingsSteps to Test This Pull Request
Add this to pyproject.tomp in existing project using conventional_commits and update_changelog_on_bump = true:
do
cz bump --dry-runand observe that changelog headers have gitmoji.Test that other behavior is identical to unpatched version
test that
bump_map = {"^.+!$" = "MAJOR", "^feat" = "MAJOR", "^fix" = "MINOR", "^refactor" = "MINOR", "^perf" = "MINOR"}bumps MINOR not PATCH part on fix commit, test that other things are unchanged.Test other settings.
Additional Context
This is starting shot at #1385
To test this I copied tests for cz_customize, removed name=... from all configs there and removed the tests that don't make
sense, for example exception for missing customize section.